Cheat Engine Forum Index Cheat Engine
The Official Site of Cheat Engine
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 


Github Cheat Engine Official

 
Post new topic   Reply to topic    Cheat Engine Forum Index -> Cheat Engine
View previous topic :: View next topic  
Author Message
KéKéCoRe
Advanced Cheater
Reputation: 0

Joined: 16 Mar 2015
Posts: 94
Location: France - Lorraine - Moselle (57)

PostPosted: Fri Mar 10, 2017 1:49 pm    Post subject: Github Cheat Engine Official Reply with quote

I do not see my program changes in Github, on the cover page of cheat engine Github ..

I would like it to be included officially. It's mostly display bug fixes.

I have seen some errors and I corrected them but I see that on my personal page, cheat engine gitbub ..


So, that I got shit to find, and to help for its to be much more comprehensible.Thank you,again! Smile



Github change.png
 Description:
 Filesize:  140.44 KB
 Viewed:  960 Time(s)

Github change.png



Github,cheat engine page of me.png
 Description:
 Filesize:  60.04 KB
 Viewed:  967 Time(s)

Github,cheat engine page of me.png



Github,home page.png
 Description:
 Filesize:  54.72 KB
 Viewed:  967 Time(s)

Github,home page.png




Last edited by KéKéCoRe on Fri Mar 10, 2017 2:03 pm; edited 1 time in total
Back to top
View user's profile Send private message Send e-mail Yahoo Messenger
Csimbi
Grandmaster Cheater Supreme
Reputation: 66

Joined: 14 Jul 2007
Posts: 1870

PostPosted: Fri Mar 10, 2017 1:56 pm    Post subject: Reply with quote

Not sure what your goal is but good luck!
Back to top
View user's profile Send private message
STN
I post too much
Reputation: 28

Joined: 09 Nov 2005
Posts: 2228

PostPosted: Fri Mar 10, 2017 2:10 pm    Post subject: Reply with quote

Maybe DB didn't consider them important to be included to CE?
_________________
Cheat Requests/Tables- Fearless Cheat Engine
http://fearlessrevolution.com/index.php
Back to top
View user's profile Send private message
KéKéCoRe
Advanced Cheater
Reputation: 0

Joined: 16 Mar 2015
Posts: 94
Location: France - Lorraine - Moselle (57)

PostPosted: Fri Mar 10, 2017 2:11 pm    Post subject: Csimbi's answer & STN's answer Reply with quote

Csimbi's answer
I doubt it ah! But it's just level fixes for translations! Above all, the one in French as well as to translate and correctly, and that its is understandable and worthy of quality.

Otherwise, I know nothing programming, finally a little but in the field of electrotechnical automation. But it is the same, but different.

I have just added a picture on the button, 'set shortcut' the one I corrected, if you download my translation in French, in the 'settings' section 'key shortcuts' a button and too small, and I found it and I corrected the problem but what I do not see my correction on cheat engine Github. I put strength to translate well and that its really professional as translation.


STN's answer
It's just a fix for displaying the translation, it is ugly if not, especially that it's free more! So I do not see why, its should not be taken into account especially that it is to correct some minor bug so that its is prettier and more professional for a program like this
Back to top
View user's profile Send private message Send e-mail Yahoo Messenger
Csimbi
Grandmaster Cheater Supreme
Reputation: 66

Joined: 14 Jul 2007
Posts: 1870

PostPosted: Fri Mar 10, 2017 2:18 pm    Post subject: Reply with quote

You do understand that the changes you make in your fork are visible only in your own build, right?
Also, none of the changes in CE are automatically taken over to your fork since you made your own fork.
Back to top
View user's profile Send private message
KéKéCoRe
Advanced Cheater
Reputation: 0

Joined: 16 Mar 2015
Posts: 94
Location: France - Lorraine - Moselle (57)

PostPosted: Fri Mar 10, 2017 2:56 pm    Post subject: Reply with quote

Yes, that's it, and I'd just like the masters in the official
And it will surely still have corrections for later still as I have not translated everything
Especially as I make the corrections on the sheet of the official but it does not put, that at home


Last edited by KéKéCoRe on Fri Mar 10, 2017 2:59 pm; edited 1 time in total
Back to top
View user's profile Send private message Send e-mail Yahoo Messenger
bengast
Newbie cheater
Reputation: 0

Joined: 11 Aug 2015
Posts: 23
Location: somewhere

PostPosted: Fri Mar 10, 2017 2:58 pm    Post subject: Reply with quote

Just download the branch they're working on and then commit all your changes and then DB will see them.
Back to top
View user's profile Send private message
Dark Byte
Site Admin
Reputation: 326

Joined: 09 May 2003
Posts: 19343
Location: The netherlands

PostPosted: Fri Mar 10, 2017 3:01 pm    Post subject: Reply with quote

you need to send pull requests on github to my branch, then i can review and appky them if they are good. ( on my view:
https://github.com/cheat-engine/cheat-engine/pulls?q=is%3Apr+is%3Aclosed )

also adjusting width and height is not a good solution. instead autosize should be used and anchors on the controls and around them should be applied.

e.g override the font and set the the size to 19. that will usually also show translation error spots

_________________
Do not ask me about online cheats. I don't know any and wont help finding them.
Back to top
View user's profile Send private message MSN Messenger
Display posts from previous:   
Post new topic   Reply to topic    Cheat Engine Forum Index -> Cheat Engine All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB © 2001, 2005 phpBB Group

CE Wiki   IRC (#CEF)   Twitter
Third party websites